[Webkit-unassigned] [Bug 131044] REGRESSION(r166395): It made all media tests crash on EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131044





--- Comment #14 from Jer Noble <jer.noble at apple.com>  2014-10-09 10:42:05 PST ---
(In reply to comment #13)
> I think it would be helpful if someone would state what the fix is meant to do.
> 
> It looks like the issue is that the 'setPseudo' call in the constructor causes an error when the m_innerText of a TextFieldInputType class is accessed. Apparently this does not yet exist during construction time.

Yeah, if you're calling a virtual method (Element::attributeChanged()) from a constructor you're going to have a bad time. (<meme>)

> It seems strange to have to set these attributes of the class after construction, but I guess it's no worse than the existing need to call 'setType' or 'ensureUserAgentShadowRoot' after the object is constructed.
> 
> This seems like clunky design, but I'm not sure how to address it at this point.

I don't think there's a better way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.