[Webkit-unassigned] [Bug 21562] Layering violation: MediaPlayer should not reference/use FrameView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 9 10:31:36 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=21562





--- Comment #14 from Jer Noble <jer.noble at apple.com>  2014-10-09 10:31:30 PST ---
(In reply to comment #12)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > But also, maybe there’s a more abstract way to describe this. It seems like a concept layering violation for the media player to even have a concept of “in media document”, so it would be nice to change this concept to instead express what behavior we expect from the media player rather than the situation.
> > 
> > I don't really know why it's needed to know whether the media player is in a media document. It's only used by mac.
> 
> OK. Maybe some Mac expert can improve this later.

This is only used from within our MediaPlayerPrivateQTKit code, so that, when we see media with non-video / non-audio tracks (say, "qtvr" or "rtsp"), we can signal to the MediaDocument that it should fall back to a PluginDocument and use the QuickTime plugin to render that media.

That said, there's no reason why media document knowledge has to be down in QTKit. Instead of only sending a mediaPlayerSawUnsupportedTracks() message from MediaPlayerPrivateQTKit when it's in a media document, it could always send that message, and the HTMLMediaElement could ignore it unless it's in a media document.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list