[Webkit-unassigned] [Bug 137541] Errors using git-add-reviewer on a branch whose name includes parentheses

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137541





--- Comment #8 from Dana Burkart <dburkart at apple.com>  2014-10-09 10:16:09 PST ---
Also, upon second look at this script, it turns out we are *not* correctly using the return code from any of the system() calls. For example, the following system() call:

>    my $result = system "git cherry-pick -n $item->{commit} > /dev/null";
>    !$result or return fail("Failed to cherry-pick $item->{commit}");

The perl documentation for the system command states that system returns the result from the wait() system call (http://perldoc.perl.org/functions/system.html), which is the _pid_ of the subprocess, not the return value.

To get the return value, we must shift by 8, i.e.:

    my $result = system "git cherry-pick -n $item->{commit} > /dev/null";
    !($result >> 8) or return fail("Failed to cherry-pick $item->{commit}");

Maybe this is out of the scope of this bug, but it needs fixing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.