[Webkit-unassigned] [Bug 136818] [AX] Improve AccessibilityTableCell columnHeaders and rowHeaders functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136818





--- Comment #16 from Andrzej Badowski <a.badowski at samsung.com>  2014-10-09 07:28:36 PST ---
(From update of attachment 239470)
View in context: https://bugs.webkit.org/attachment.cgi?id=239470&action=review

>> Source/WebCore/accessibility/AccessibilityTableCell.cpp:160
>> +        if (parentNode->hasTagName(tfootTag)) {
> 
> this looks good for tfoot, but doesn't the same thing apply to body?
> 
> For example, this is from w3c
> 
> <tbody>
>   <tr>
>    <td>Ms Danus
>    <td>Doughnuts
>    <td><img src="http://example.com/mydoughnuts.png" title="Doughnuts from Ms Danus">
>    <td>$45
>   <tr>
>    <td><input id=e1 type=text name=who required form=f>
>    <td><input id=e2 type=text name=what required form=f>
>    <td><input id=e3 type=url name=pic form=f>
>    <td><input id=e4 type=number step=0.01 min=0 value=0 required form=f>
> </table>
> -------------
> I wouldn't expect each of these cells to be a row header

I agree with you. Although in this particular case I am not afraid that any td element will be qualified as rowheader or columnheader because they do not have a scope attribute. All of the code of classification based on the location inside the table only applies to th element. This is ensured by a prior call to isTableHeaderCell. Of course, I will repeat the same thing for tbody.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.