[Webkit-unassigned] [Bug 137434] [JSC] Segfault on ARM64 with gcc in elf_dynamic_do_Rela

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137434


Akos Kiss <akiss at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239299|0                           |1
        is obsolete|                            |
 Attachment #239299|review?, commit-queue?      |
               Flag|                            |
 Attachment #239527|                            |review?, commit-queue?
               Flag|                            |




--- Comment #4 from Akos Kiss <akiss at inf.u-szeged.hu>  2014-10-09 04:47:11 PST ---
Created an attachment (id=239527)
 --> (https://bugs.webkit.org/attachment.cgi?id=239527&action=review)
Proposed patch, v2

You're right, .previous works -- on my ARM64/Linux at least. (On that box, I've been experimenting with some corner cases to check that different compilers -- gcc & clang -- behave as expected, and found no issues, fortunately. I've also tried out some .pushsection/.popsection-based approaches but all turned out to need more and potentially harder to maintain changes.) I could not validate the patch for iOS.

Interestingly, all the other defines use the same .text-based approach for defining the thunks with no .data/.previous/.pushsection-.popsection around and noone ran into this problem before. Still I guess that it would be safer to have .previous in those macros as well, but following the "if it's not broken, don't fix it" line, I've made no changes there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.