[Webkit-unassigned] [Bug 136818] [AX] Improve AccessibilityTableCell columnHeaders and rowHeaders functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136818





--- Comment #13 from Andrzej Badowski <a.badowski at samsung.com>  2014-10-08 05:46:35 PST ---
(From update of attachment 239405)
View in context: https://bugs.webkit.org/attachment.cgi?id=239405&action=review

>> Source/WebCore/accessibility/AccessibilityTableCell.cpp:133
>> +    for ( ; parentNode; parentNode = parentNode->parentNode()) {
> 
> I think you can put
> Node* parentNode = node(); 
> inside the for loop here
> I don't see you using it again outside the for loop

You're right. The code will be more compact.

>> Source/WebCore/accessibility/AccessibilityTableCell.cpp:156
>> +    for ( ; parentNode; parentNode = parentNode->parentNode()) {
> 
> ditto about parentNode

OK

>> Source/WebCore/accessibility/AccessibilityTableCell.cpp:157
>> +        if (parentNode->hasTagName(tbodyTag) || parentNode->hasTagName(tfootTag))
> 
> Why are row headers == to being inside tfoot? while column headers are == to being inside thead? 
> it doesn't seem like those things have to be equal. 
> 
> I can see thead elements would probably be column headers (unless it's the first cell in the thead, in which case it might be a row header)
> But for tfoot contained elements, I don't see why those would be row headers

While I well understand your intention. I think that it is worth at this point further clarify the meaning of the th element within the tfoot. The situation is such that the author of the html code did not use a chance to resolve the meaning of the th element with the scope. It seems to me that deciding instead of someone (beyond the first cell in a row), it would be overinterpretation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.