[Webkit-unassigned] [Bug 137278] Web Inspector: add 2D/WebGL canvas instrumentation infrastructure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137278





--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org>  2014-10-07 16:57:14 PST ---
(From update of attachment 239375)
View in context: https://bugs.webkit.org/attachment.cgi?id=239375&action=review

> Source/WebCore/inspector/InspectorCanvasAgent.cpp:62
> +void InspectorCanvasAgent::willDestroyFrontendAndBackend(InspectorDisconnectReason)

Seems this should call disable.

> Source/WebCore/inspector/InspectorCanvasAgent.cpp:72
> +    int id = idForCanvas(canvas);
> +    if (id)
> +        return;

Should this ASSERT(!id)? didCreate shouldn't happen for an existing canvas, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.