[Webkit-unassigned] [Bug 15256] Impossible to place an editable selection inside empty elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15256


David Gatwood <dgatwood at mac.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238899|0                           |1
        is obsolete|                            |




--- Comment #46 from David Gatwood <dgatwood at mac.com>  2014-10-06 23:21:30 PST ---
Created an attachment (id=239395)
 --> (https://bugs.webkit.org/attachment.cgi?id=239395&action=review)
Final HTML editing caret patch

Whew.  I think I've fixed the last crasher bugs and caret positioning bugs (or at least the last layout bugs that I introduced).  I also rewrote a bunch of the caret positioning code for block elements in a different way that's a lot cleaner.  I've also updated it to be based on TOT as of a couple of days ago, which required inlining a bunch of recently removed macros.  Hope this helps.

If and when you take these fixes, you'll probably need to do two additional things:

* Finish fixing up the text cases as needed.  Although I attempted to merge the test case changes from Blink, I know nothing about how your test suite is designed (or theirs), so I had basically no idea what I was doing during that marge.  As a result, the test case parts of this patch may be completely and utterly wrong.  You have been warned.  :-)
* Check the original Blink patches to see if you need to introduce any new copyright lines into the modified files.  I didn't notice any such additions in the failed patches as I applied them, but a second set of eyes couldn't hurt.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.