[Webkit-unassigned] [Bug 136150] [ATK] Changing the mapping of aria rowheader and columnheader into respective ATK roles.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136150





--- Comment #22 from Andrzej Badowski <a.badowski at samsung.com>  2014-10-06 08:24:29 PST ---
(From update of attachment 239114)
View in context: https://bugs.webkit.org/attachment.cgi?id=239114&action=review

>> LayoutTests/accessibility/table-roles-hierarchy.html:13
>> +    {
> 
> brace goes on previous line

OK

>> LayoutTests/accessibility/table-roles-hierarchy.html:19
>> +    {
> 
> brace goes on previous line

OK

>> LayoutTests/accessibility/table-roles-hierarchy.html:25
>> +    {
> 
> brace goes on previous line

OK

>> LayoutTests/accessibility/table-roles-hierarchy.html:36
>> +          if ( childAXObject.role != "AXRole: AXStaticText")
> 
> extra space after (

OK

>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2573
>> +        while (node) {
> 
> this can be written as a for loop
> for (node = node->parentNode(); node; node = node->parentNode())

The for loop is very good...

>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2578
>> +            if (node->hasTagName(tableTag))
> 
> are you sure you want to make a <Table> into a CellRole?

Please note that tableTag at this point means that th element has no parent or the parent's parent and so on, which would be theadTag, tbodyTag or tfootTag item. In this situation, the decision for the original thTag is CellRole. Use tableTag lets stop checking on tableTag and not for example on body tag or html tag.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.