[Webkit-unassigned] [Bug 137300] [SOUP] TLS errors should take precedence over HTTP authentication

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137300





--- Comment #5 from Sergio Villar Senin <svillar at igalia.com>  2014-10-06 01:05:01 PST ---
(From update of attachment 239022)
View in context: https://bugs.webkit.org/attachment.cgi?id=239022&action=review

The change looks conceptually good to me. I was wondering if it wouldn't be better to listen to tls-errors notifications from the SoupMessage instead of having to handle these things in different parts of our code...

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:-577
> -    if (!response.soupMessageTLSErrors() || gIgnoreSSLErrors)

I guess this deserves a comment explaining that in the case of authentication challenge, the response has not been updated with the SoupMessage contents yet.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:593
> +    handle->client()->didFail(handle, ResourceError::tlsError(d->m_soupRequest.get(), tlsErrors, certificate));

So I guess both soupMessageCertificate() and soupMessageTLSErrors() became unused methods with these changes. Time to remove them?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.