[Webkit-unassigned] [Bug 137389] [GTK] Do not generate a symlink in derived sources for every header in WebCore/bindings/gobject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137389





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2014-10-03 09:01:25 PST ---
(From update of attachment 239199)
View in context: https://bugs.webkit.org/attachment.cgi?id=239199&action=review

> Source/WebCore/PlatformGTK.cmake:770
> +# Some of the static headers are included by generated public headers with include <webkitdom/WebKitDOMFoo.h>.
> +# We need those headers in the derived sources to be in webkitdom directory.
> +add_custom_command(
> +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMCustom.h
> +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustom.h
> +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustom.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
> +)
> +add_custom_command(
> +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMEventTarget.h
> +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMEventTarget.h
> +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMEventTarget.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
> +)
> +add_custom_command(
> +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMNodeFilter.h
> +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMNodeFilter.h
> +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMNodeFilter.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
> +)
> +add_custom_command(
> +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMObject.h
> +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMObject.h
> +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMObject.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
> +)
> +add_custom_command(
> +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMXPathNSResolver.h
> +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMXPathNSResolver.h
> +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMXPathNSResolver.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
> +)
> +add_custom_target(fake-generated-webkitdom-headers
> +    DEPENDS ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMCustom.h
> +            ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMEventTarget.h
> +            ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMNodeFilter.h
> +            ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMObject.h
> +            ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMXPathNSResolver.h

I think there are a couple ways to make this a little cleaner. One is to use a macro and a list of file names (you could even omit the directories). The other is to use a single add_custom_command with multiple outputs and dependencies.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.