[Webkit-unassigned] [Bug 126324] configure check for clang version is incorrect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126324


Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org




--- Comment #5 from Michael Catanzaro <mcatanzaro at gnome.org>  2014-10-03 07:22:47 PST ---
Note that the autotools build was removed for 2.6.

The version check is indeed incorrect and will break when GCC 5 is released next spring, but the proposed fix is wrong too. The right hand side of the || will always be short-circuited:

(__GNUC__ >= 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 7)

You want:

(__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 7)

The altered Clang version check is correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.