[Webkit-unassigned] [Bug 137110] [GTK] Implement is_selected method on WebKitHitTestResult

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137110


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239089|                            |commit-queue-
               Flag|                            |




--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-10-02 01:44:57 PST ---
(From update of attachment 239089)
View in context: https://bugs.webkit.org/attachment.cgi?id=239089&action=review

Looks good to me, apart from the minor issues I mentioned.

> Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp:367
> + * Since 2.8.

Since: 2.8

> Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.h:55
> + * Since 2.8.

This here means the enum was introduced in 2.8, but it's only the value. You should add the Since tag after the flag.

* @WEBKIT_HIT_TEST_RESULT_CONTEXT_SELECTION: a selected element. Since 2.8

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:408
> +    // Context menu for selection.
> +    test->m_expectedMenuType = ContextMenuDefaultTest::Selection;
> +    test->showContextMenuAtPositionAndWaitUntilFinished(2, 115);

I guess this should go first because otherwise any other click would remove the selection, right? I would add a comment explaining why this should always be the first check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.