[Webkit-unassigned] [Bug 128177] [EFL] Switch to CUSTOM_PROTOCOLS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128177





--- Comment #13 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-10-01 17:28:45 PST ---
(From update of attachment 239030)
View in context: https://bugs.webkit.org/attachment.cgi?id=239030&action=review

> Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.h:47
> +    }

Add a new line.

> Tools/MiniBrowser/efl/main.c:75
> +static void about_url_scheme_request_cb(Ewk_Url_Scheme_Request *request, void *user_data)

> I think it is perfectly fine
> - It's actually a copy paste from "ewk_context.h" (ewk_context_url_scheme_register() API documentation)
> - This "about" indicates which new scheme we are implementing (the I guess each new scheme callback would have its own prefix)
> - It is consistent with GTK aboutURISchemeRequestCallback() naming

EFL MiniBrowser is EFL simple application, not WebKit library. So we have used EFL coding style and naming so far. If you see other functions in main.c, you can find EFL style naming. If this is WebKit side implementation, I agree with your opinion. However, MiniBrowser is EFL simple application. But, in this case, it looks not critical. I'm OK, if you want to keep it.

> Tools/MiniBrowser/efl/main.c:83
> +        // FIXME:

Unneeded line break. Below is enough.

// FIXME: Initialize contents bla bar..

> Tools/MiniBrowser/efl/main.c:2382
> +    ewk_context_url_scheme_register(context, MINIBROWSER_ABOUT_SCHEME, about_url_scheme_request_cb, NULL);

Should you call this function here ? Basically we have initialized ewk APIs in window_create().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.