[Webkit-unassigned] [Bug 137303] commitqueuetasks_unittest references a non-existent member variable when mock-reporting flakey tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137303


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239048|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Daniel Bates <dbates at webkit.org>  2014-10-01 14:28:06 PST ---
(From update of attachment 239048)
View in context: https://bugs.webkit.org/attachment.cgi?id=239048&action=review

> Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:338
> +    def test_simple_flakey_test_failure(self):

Nit: flakey => flaky

For consistency with the majority of the Python code, including the naming of the function report_flaky_tests() and local variable flaky_tests, we should use "flaky" instead of "flakey". We should look to fix up the few places in the Python code where we use the word "flakey".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.