[Webkit-unassigned] [Bug 137303] commitqueuetasks_unittest references a non-existent member variable when mock-reporting flakey tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137303





--- Comment #5 from Daniel Bates <dbates at webkit.org>  2014-10-01 13:46:00 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 239033 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=239033&action=review
> > > 
> > > > Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:80
> > > >      def report_flaky_tests(self, patch, flaky_results, results_archive):
> > > > -        flaky_tests = [result.filename for result in flaky_results]
> > > > +        flaky_tests = [result.test_name for result in flaky_results]
> > > >          _log.info("report_flaky_tests: patch='%s' flaky_tests='%s' archive='%s'" % (patch.id(), flaky_tests, results_archive.filename))
> > > 
> > > How did you come to the decision to fix this code as opposed to removing it? I mean, you mentioned in comment #0 that this is "unexcercised [sic] code". We should not keep unused code in the tree.
> > 
> > I found this bug because one of the changes I was going to make exercised this code. Although it's not exercised as of this moment, it likely will be in the near future. Probably by me.
> 
> As mentioned in-person today (10/01), we should either add a test for this change (to ensure we don't break it again) or remove this code (we can always add an implementation for this method or add back the entire method when we actually make use of it)

*...we can always add a non-trivial implementation...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.