[Webkit-unassigned] [Bug 128177] [EFL] Switch to CUSTOM_PROTOCOLS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128177


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239027|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-10-01 09:01:56 PST ---
(From update of attachment 239027)
View in context: https://bugs.webkit.org/attachment.cgi?id=239027&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request.cpp:80
> +    WebCore::ResourceResponse response(WebCore::URL(WebCore::URL(), String::fromUTF8(m_url)),
> +        String::fromUTF8(mimeType), contentLength, emptyString());
> +
> +    toImpl(m_wkRequestManager.get())->didReceiveResponse(m_requestID, response);
> +    toImpl(m_wkRequestManager.get())->didLoadData(m_requestID, toImpl(wkData.get()));
> +    toImpl(m_wkRequestManager.get())->didFinishLoading(m_requestID);
> +    toImpl(m_wkRequestManager.get())->stopLoading(m_requestID);

So, you send the whole data in a single chunk to the networking process?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:119
>      ewk_context_url_scheme_register(ewk_view_context_get(webView()), "fooscheme", schemeRequestCallback, 0);

0 -> nullptr

> Source/WebKit2/UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:36
>  #endif
>  
> +#if PLATFORM(EFL)

#elif ?

> Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.h:45
> +        : m_callback(0)
> +        , m_userData(0)

nullptr

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:38
> +#if ENABLE(CUSTOM_PROTOCOLS)
> +#include "WebSoupCustomProtocolRequestManager.h"
> +#else
>  #include "WebSoupRequestManagerProxy.h"
> +#endif

Is this really possible? You removed WebSoupRequestManagerProxy from the makefile no?

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:100
> +#if ENABLE(CUSTOM_PROTOCOLS)
> +    parameters.urlSchemesRegisteredForCustomProtocols = supplement<WebSoupCustomProtocolRequestManager>()->registeredSchemesForCustomProtocols();
> +#else
>      parameters.urlSchemesRegistered = supplement<WebSoupRequestManagerProxy>()->registeredURISchemes();
> +#endif

Ditto.

> Source/WebKit2/UIProcess/soup/WebContextSoup.cpp:46
> +#else
> +    parameters.urlSchemesRegistered = supplement<WebSoupRequestManagerProxy>()->registeredURISchemes();

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.