[Webkit-unassigned] [Bug 139108] New: Track pages preventing suppression in WebProcessProxy using RefCounter (instead of HashSet)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 29 23:47:01 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=139108

            Bug ID: 139108
           Summary: Track pages preventing suppression in WebProcessProxy
                    using RefCounter (instead of HashSet)
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: barraclough at apple.com

The networking process is allowed to app nap if all web pages are also currently in app nap.*

In order to detect whether any page in any process currently requires the networking process to be active we:
 - maintains hash sets in every WebProcessProxy of pages that are okay with suppression.
 - if anything changes, the WebContext iterates every WebProcessProxy to recompute state.
This is all crazy - all we actually need is a simple count of the number of pages that need to prevent the networking process from entering app nap.

This patch gets us half way there - replace the HashSet with a RefCounter. Next step will be to hoist the RefCounters from the process proxies up to the context to do away with the iteration.

(* Actually, more specifically the networking process will app nap if all pages are visually idle - that's probably a bug, we're failing to take media & page load state into account.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141130/3d558b4f/attachment-0002.html>


More information about the webkit-unassigned mailing list