[Webkit-unassigned] [Bug 133070] Remove unused JSC runtime options

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 28 03:24:27 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=133070

--- Comment #3 from Csaba Osztrogonác <ossy at webkit.org> ---
Comment on attachment 231691
  --> https://bugs.webkit.org/attachment.cgi?id=231691
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231691&action=review

>> Source/JavaScriptCore/runtime/Options.h:-149
>> -    v(bool, enableExperimentalFTLCoverage, false) \
> 
> It is unused now, but we shouldn't remove it until FTL is complete.
> I think JSC developers will need this to add new experimental features.

It is still unused. Can we remove it?

>> Source/JavaScriptCore/runtime/Options.h:-197
>> -    v(unsigned, maximumInliningRecursionForMustInline, 3) \
> 
> These options were introduced by the cstack merge and were unused from the beginning.
> Were they used only for developing in the branch?

After a half year later, I still can't find any use of maximumInliningDepthForMustInline and maximumInliningRecursionForMustInline
in the full git history. I think they aren't used ever. Any objection against removing them?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141128/cb5f8e0a/attachment-0002.html>


More information about the webkit-unassigned mailing list