[Webkit-unassigned] [Bug 139028] Enable depth 32 for the RedirectedXCompositeWindow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 25 01:38:31 PST 2014


--- Comment #6 from Gwang Yoon Hwang <yoon at igalia.com> ---
Comment on attachment 242162
  --> https://bugs.webkit.org/attachment.cgi?id=242162
gtk: support RGBA end-to-end compositing when using RedirectedXCompositeWindow

View in context: https://bugs.webkit.org/attachment.cgi?id=242162&action=review

> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:135
> +RedirectedXCompositeWindow::RedirectedXCompositeWindow(Display* display, const IntSize& size, std::function<void()> damageNotify, int depth)

Because your patch adds Alpha support to current implementation, it would be good to use "bool supportAlpha" instead of depth.

> Tools/MiniBrowser/gtk/main.c:64
> +    // FIXME: use websettings

I don't think we need to use websettings.
It would be better to modify WebKitWebViewBase to decide whether RGBA support is needed.
ex) If parent window of webview uses RGBA, we can use RGBA support.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141125/293c36db/attachment-0002.html>

More information about the webkit-unassigned mailing list