[Webkit-unassigned] [Bug 138090] [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 24 23:38:55 PST 2014


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #241552|review?                     |review-
              Flags|                            |

--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 241552
  --> https://bugs.webkit.org/attachment.cgi?id=241552

View in context: https://bugs.webkit.org/attachment.cgi?id=241552&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:448
> +static void browser_window_zoom_in(BrowserWindow *window)

Private methods should follow the WebKit coding style, this should be browserWindowZoomIn

> Tools/MiniBrowser/gtk/BrowserWindow.c:456
> +static void browser_window_zoom_out(BrowserWindow *window)


> Tools/MiniBrowser/gtk/BrowserWindow.c:470
> +        return isEventHandled;

This is the only place where we return FALSE, so I think we don't need the local variable, simply return FALSE here directly and TRUE after the if

> Tools/MiniBrowser/gtk/BrowserWindow.c:480
> +    return isEventHandled;

This is always TRUE at this point due to the early return. But the event was actually handled only if the zoom happened. You could make zoom in/out functions bool and return False when the view can't zoom, and return that value directly here.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141125/0aec6bc9/attachment-0002.html>

More information about the webkit-unassigned mailing list