[Webkit-unassigned] [Bug 139019] Use std::unique_ptr instead of PassOwnPtr|OwnPtr for Pasteboard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 24 07:38:23 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=139019

--- Comment #8 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 242159
  --> https://bugs.webkit.org/attachment.cgi?id=242159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242159&action=review

> Source/WebCore/editing/Editor.cpp:860
> +        std::unique_ptr<Pasteboard> pasteboard = Pasteboard::createForCopyAndPaste();

Why not using auto ?

> Source/WebCore/page/mac/EventHandlerMac.mm:684
> +    std::unique_ptr<Pasteboard> pasteboard = return std::make_unique<Pasteboard>(NSDragPboard);

return ??????????

> Source/WebCore/platform/win/PasteboardWin.cpp:95
> +    std::unique_ptr<Pasteboard> pasteboard = std::make_unique<Pasteboard>();

ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141124/f513a7be/attachment-0002.html>


More information about the webkit-unassigned mailing list