[Webkit-unassigned] [Bug 139019] Use std::unique_ptr instead of PassOwnPtr|OwnPtr for Pasteboard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 24 00:47:16 PST 2014


Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #242146|review?                     |review-
              Flags|                            |

--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 242146
  --> https://bugs.webkit.org/attachment.cgi?id=242146

View in context: https://bugs.webkit.org/attachment.cgi?id=242146&action=review

r- because of create() factory function and wrong std::unique_ptr<> use.

> Source/WebCore/platform/mac/PasteboardMac.mm:128
> +    return std::unique_ptr<Pasteboard>(new Pasteboard(pasteboardName));

We decided not to use create() factory function. Instead we have to use std::make_unique<> except for specific cases.

> Source/WebCore/platform/win/PasteboardWin.cpp:114
> +    return std::unique_ptr<Pasteboard>(new Pasteboard(dataObject.get()));

Use std::make_unique<> instead of std::unique_ptr<>

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141124/71033795/attachment-0002.html>

More information about the webkit-unassigned mailing list