[Webkit-unassigned] [Bug 138828] [GTK] Add API to override the default local storage directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138828

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241787|review?                     |review+
              Flags|                            |

--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org> ---
Comment on attachment 241787
  --> https://bugs.webkit.org/attachment.cgi?id=241787
It should apply now

View in context: https://bugs.webkit.org/attachment.cgi?id=241787&action=review

So no convenience _new? I think that is ok, but worth noting so you can consider =)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:255
> +    WebKitWebContext* webContext = WEBKIT_WEB_CONTEXT(object);
> +    WebKitWebContextPrivate* priv = webContext->priv;

It doesn't hurt my eyes, but this should move to before the priv->localStorageDictory.isNull check in theory.

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:42
> +    // Local Sorage Directory.

This doesn't add much information, I'd do away with it - the variable name is enough documentation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141121/ac8beca6/attachment-0002.html>