[Webkit-unassigned] [Bug 136449] [GTK] UserMedia Permission Request API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136449

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241934|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #19 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 241934
  --> https://bugs.webkit.org/attachment.cgi?id=241934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241934&action=review

The GTK+ API looks good to me, please ask a WebKit2 owner to review the cross-platform changes before landing. Thanks!

> Source/WebCore/platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:76
> +    // FIXME: fill source vectors

Nit: finish the comment with period. A bug link for these FIXMEs would be great too.

> Source/WebKit2/UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp:23
> +#include "WebKitEnumTypes.h"

I don't think you need this

> Source/WebKit2/UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp:27
> +#include <wtf/text/CString.h>

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitUserMediaPermissionRequestPrivate.h:25
> +WebKitUserMediaPermissionRequest* webkitUserMediaPermissionRequestCreate(WebKit::UserMediaPermissionRequestProxy&, WebKit::WebSecurityOrigin&);

I wonder why you don't need to include UserMediaPermissionRequestProxy.h or forward declare the class, same for WebSecurityOrigin. I guess there's something in WebKitPrivate.h

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141121/4c113479/attachment-0002.html>