[Webkit-unassigned] [Bug 138943] Preview popover needs minimum and maximum sizes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138943

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242009|review?                     |review+
              Flags|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 242009
  --> https://bugs.webkit.org/attachment.cgi?id=242009
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242009&action=review

> Source/WebKit2/ChangeLog:12
> +        _hitTestResult, so we should computer a new origin rect based on the original 

computer!!

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:398
> +    if (targetSizeFitsInAvailableSpace(targetSize, maxSpaceAvailableOnYEdge) && targetSizeFitsInAvailableSpace(targetSize,largestPopoverSize))

you're missing some spaces after your commas

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141121/104d5fd0/attachment-0002.html>