[Webkit-unassigned] [Bug 138878] The buildbot dashboard should be compatible with buildbot-0.8.9

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 19 15:53:57 PST 2014


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
 Attachment #241894|review?                     |review+
              Flags|                            |

--- Comment #7 from Mark Rowe (bdash) <mrowe at apple.com> ---
Comment on attachment 241894
  --> https://bugs.webkit.org/attachment.cgi?id=241894
Dashboard patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241894&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:106
> +    if (isMultiCodebaseGotRevisionProperty(property)) {
> +        value = (key in value) ? value[key] : value[fallbackKey];
> +    }

The braces are not necessary around the body of this if statement since it's only a single line.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141119/b6af951c/attachment-0002.html>

More information about the webkit-unassigned mailing list