[Webkit-unassigned] [Bug 138878] The buildbot dashboard should be compatible with buildbot-0.8.9

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138878

--- Comment #5 from Mark Rowe (bdash) <mrowe at apple.com> ---
Comment on attachment 241883
  --> https://bugs.webkit.org/attachment.cgi?id=241883
Simplify previous patch to isolate the issue

View in context: https://bugs.webkit.org/attachment.cgi?id=241883&action=review

> Tools/ChangeLog:3
> +        Make the dashboard compatible with buildbot-0.8.9 revision info.

This doesn't really describe the issue since the dashboard was already compatible with v0.8.9. This is teaching it to cope with the fact that different masters may have different names for the codebases.

> Tools/ChangeLog:9
> +        (isMultiCodebaseGotRevisionProperty):

This is no longer modified in your patch.

> Tools/ChangeLog:10
> +        (parseRevisionProperty): Changed.

Needs a description of what's changed and why.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:104
> +    if (typeof value === "object") {

Shouldn't this check be: if (isMultiCodebaseGotRevisionProperty(property)) {

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:109
> +        if (key in value) {
> +            value = value[key];
> +        } else {
> +            value = value[fallbackKey];
> +        }

This could be:
value = value[key] || value[fallbackKey];

Or if you want to be paranoid about falsey values:

value = (key in value) ? value[key] : value[fallbackKey];

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141119/8f2ac5f5/attachment-0002.html>