[Webkit-unassigned] [Bug 110350] ASSERT(upstreamStart.deprecatedNode()->isDescendantOf(enclosingBlock(upstreamEnd.deprecatedNode()))) in CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 18 02:14:17 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=110350

--- Comment #15 from Csaba Osztrogonác <ossy at webkit.org> ---
(In reply to comment #14)
> Comment on attachment 233695 [details]
> Patch
> 
> This patch seems kind of strange. It removes an assertion, without any
> explanation of why except that Chromium already removed it. We need to
> explain changes. It’s obvious that removing an assertion will make the crash
> intentionally caused by the assertion go away. What’s not obvious is whether
> there is some kind of problem left behind. Some editing export should review
> this and explain why no assertion is needed here.

https://src.chromium.org/viewvc/blink?revision=175118&view=revision explained
that this assert was based on false assumption and added a test case where
this assert fires incorrectly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141118/741296b7/attachment-0002.html>


More information about the webkit-unassigned mailing list