[Webkit-unassigned] [Bug 133359] [CSS Grid Layout] Upgrade align-self and align-items parsing to CSS 3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133359

--- Comment #83 from Andreas Kling <akling at apple.com> ---
Comment on attachment 241719
  --> https://bugs.webkit.org/attachment.cgi?id=241719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241719&action=review

> Source/WebCore/css/StyleResolver.cpp:1377
> +    if (style.alignItems() == ItemPositionAuto) {
> +        if (style.isDisplayFlexibleOrGridBox())
> +            style.setAlignItems(ItemPositionStretch);
> +        else
> +            style.setAlignItems(ItemPositionStart);
> +    }
> +
> +    // The 'auto' keyword computes to 'stretch' on absolutely-positioned elements,
> +    // and to the computed value of align-items on the parent (minus
> +    // any 'legacy' keywords) on all other boxes (to be resolved during the layout).
> +    if (style.alignSelf() == ItemPositionAuto) {
> +        if ((style.position() == AbsolutePosition))
> +            style.setAlignSelf(ItemPositionStretch);
> +    }

Looks like we will always overwrite values in RenderStyle now. That's not good since it will cause us to copy-on-write the StyleRareNonInheritedData.
This would be my first guess for the source of the performance regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141118/1cde0f89/attachment-0002.html>