[Webkit-unassigned] [Bug 138310] Add parsing for :role()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138310

--- Comment #6 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
Sorry for the delay. I was busy with school work. Thank you very much for the review.

(In reply to comment #2)
> -The new selector should be under ENABLE(CSS_SELECTORS_LEVEL4). Sorry I did
> not mention that by mail, :role() is part of the new selectors we are adding
> for Level 4 :(

Done.

> -You should also include test for things that can go wrong, invalid input.
> For example, :role(), :role()), :role(25), :role(a, b), etc. We need to
> ensure we do not generate valid CSSSelector for invalid input.

Done.

> -You should include tests covering uppercase and lowercase. We still need to
> define how case-sensitivity will work with :role(), in the meantime we
> should make sure the behavior is tested so that some tests would break when
> the behavior changes.

Done?

> -I have recently added the test
> fast/selectors/invalid-functional-pseudo-class.html for functional pseudo
> class. Can you add :role() there too and extend the results?

Done.

> I am a bit surprised you did not need to modify the parser.

That seemed to be wrong. The first patch generated valid CSSSelector for invalid input such as :role(42).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141116/3bcf74ae/attachment-0002.html>