[Webkit-unassigned] [Bug 136903] changing SVG <defs> does not update SVG element.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 14 15:54:52 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=136903

--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 241604
  --> https://bugs.webkit.org/attachment.cgi?id=241604
[WIP] fix.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241604&action=review

Looks good. I suggest getting in the habit of writing the ChangeLog even when posting WIP patches because it helps people understand what is going on. "prepare-ChangeLog" or "webkit-patch prepare" are your friends.

Now you need to turn defs-innerHTML.svg into a test!

> Source/WebCore/html/HTMLElement.cpp:505
> -
> +    
>  void HTMLElement::setOuterText(const String& text, ExceptionCode& ec)

Oops. You inserted some space.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141114/0d5e48a7/attachment-0002.html>


More information about the webkit-unassigned mailing list