[Webkit-unassigned] [Bug 138739] start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 14 09:03:07 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=138739
Eric Carlson <eric.carlson at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #241579|review? |review+
Flags| |
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 241579
--> https://bugs.webkit.org/attachment.cgi?id=241579
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=241579&action=review
The Blink patch includes changes to a test as well. I see we don't have dom-exceptions.html at all, but could you create it with just the start() tests?
> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:375
> + startPlaying(false, 0, 0, buffer()->duration(), ec);
Looking a startPlaying call site I have no idea what the first parameter means. I think an enum would be much better.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141114/770df4a5/attachment-0002.html>
More information about the webkit-unassigned
mailing list