[Webkit-unassigned] [Bug 137918] Use references instead of pointers in EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137918

--- Comment #11 from Csaba Osztrogonác <ossy at webkit.org> ---
Comment on attachment 241350
  --> https://bugs.webkit.org/attachment.cgi?id=241350
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=241350&action=review

> Source/WebCore/editing/EditingStyle.cpp:1550
> -    return fontWeightIsBold(extractPropertyValue(style, CSSPropertyFontWeight).get());
> +    return fontWeightIsBold(*extractPropertyValue(style, CSSPropertyFontWeight).get());

It isn't safe, extractPropertyValue() can return with nullptr.
In this case you should return false.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141113/a5428200/attachment-0002.html>