[Webkit-unassigned] [Bug 138090] [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138090

--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 240474
  --> https://bugs.webkit.org/attachment.cgi?id=240474
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240474&action=review

>> Tools/MiniBrowser/gtk/BrowserWindow.c:456
>> +    if (direction == GDK_SCROLL_UP && state == GDK_CONTROL_MASK) {
> 
> Instead of checking the state all the time, we can just return early when the state != GDK_CONTROL_MASK.

The state comparison is also wrong, since state is a bitmask you have to compare with the mask (gtk_accelerator_get_default_mod_mask()) if (state & mask == GDK_CONTROL_MASK)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141113/89fd0286/attachment-0002.html>