[Webkit-unassigned] [Bug 136449] [GTK] UserMedia Permission Request API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 13 03:47:04 PST 2014


--- Comment #11 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #9)
> > Source/WebKit2/UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp:115
> > +guint32 webkit_user_media_permission_get_media_types(WebKitUserMediaPermissionRequest* request)
> I still find this name a bit confusing, but I'm not familiar with the media
> APIs. Isn't this more about the type of request instead of the type of
> media? what about requested_media_types? does it sounds redundant?

I think it's a bit redundant yeah.

> > Source/WebKit2/UIProcess/API/gtk/WebKitUserMediaPermissionRequest.h:48
> > + * Enum values used to specify which type of media device is requested.
> If this is about media devices, what about WebKitMediaDeviceType? and
> webkit_media_permission_request_get_requested_device_types? Another option
> would be to not expose the enum, and provide methods to query this directly
> like get_requested_device_is_audio() and get_requested_device_is_video().

I don't think the enum would grow so it'd be also ok to simply use methods for this. What do Gustavo and Martin think about this?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141113/1a66a91f/attachment-0002.html>

More information about the webkit-unassigned mailing list