[Webkit-unassigned] [Bug 138090] [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138090

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 240474
  --> https://bugs.webkit.org/attachment.cgi?id=240474
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240474&action=review

>> Tools/MiniBrowser/gtk/BrowserWindow.c:790
>> +    g_signal_connect(window, "scroll_event", G_CALLBACK(mouseZoomCallback), window);
> 
> scroll_event -> scroll-event. It doesn't make sense to pass the instance pointer as user data and you are not even handling the user data in the callback. I think it would be better if you implement the scroll_event vmethod of GtkWidgetClass instead of connecting to the signal.

hmm, but we don't want to connect to the window scroll event, but to the web view scroll event instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141113/c03fb0e9/attachment-0002.html>