[Webkit-unassigned] [Bug 138557] Attribute text in HTMLAnchorElement should behave as per specification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138557

--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > It looks to be some problem in build in CodeGeneratorObjC.pm.
> > > https://bugs.webkit.org/show_bug.cgi?id=135860.
> > > Public API change. There are missing public properties and/or methods from
> > > the "DOMHTMLAnchorElement" class.
> > > @property (readonly, copy) NSString *text;
> > > Died at WebCore/bindings/scripts//CodeGeneratorObjC.pm line 386.
> > > make: *** [DOMHTMLAnchorElement.h] Error 255
> > > make: *** Waiting for unfinished jobs....
> > > Showing first 200 notices only
> > > Command /bin/sh failed with exit code 2
> > > 
> > > ** BUILD FAILED **
> > 
> > I don't know anything about the ObjC bindings so someone else will need to
> > take over. I think you'll need to update DOMHTMLAnchorElement in
> > Source/WebCore/bindings/objc/PublicDOMInterfaces.h and remove "readonly"
> > form text. However, it seems we do API versioning so it may not be as easy.
> > Dropping readonly seems like a backward compatible API change though so I am
> > not sure it is a problem. As I said, someone knowledgeable about ObjC
> > bindings should comment on this.
> 
> Dear Chris,
> 
>      Thanks for inputs, i think we need to remove "readonly" from text in
> PublicDOMInterfaces.h for DOMHTMLAnchorElement. I found some old bug:
> https://bugs.webkit.org/show_bug.cgi?id=87154, it has similar change done.
>      I will make these change and update the parch. But, as u pointed out,
> these change might drop backward compatible, so shall we do these change or
> not?

Yes, since the change suggested is trivial (and no one else commented on this yet), I would make the change to make mac ews bots happy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141113/519bd960/attachment-0002.html>