[Webkit-unassigned] [Bug 138671] New: Reduce amount of cut-and-paste needed for probe mechanism implementations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 12 14:28:16 PST 2014


            Bug ID: 138671
           Summary: Reduce amount of cut-and-paste needed for probe
                    mechanism implementations
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com

The present implementation requires that each MacroAssembler implementation provide their own copy of all of the probe implementations even when most of it is identical.  This patch reimplements the common parts into MacroAssemblerProbe.h and have each target specific MacroAssembler implementation inherit from it instead.  The target specific MacroAssembler only needs to implement a few target specific methods that are expected by and documented in MacroAssemblerProbe.h.  MacroAssembler ports that do not care to implement the probe mechanism simply need no inherit from MacroAssemblerProbe.

In this patch, I also fill out some missing xmm registers in the X86_64's FP register list.  Also simplified the X86 and X86_64 ports to use the same port implementation.

This is all done in preparation to add printing functionality in JITted code for debugging.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141112/82b83119/attachment-0002.html>

More information about the webkit-unassigned mailing list