[Webkit-unassigned] [Bug 138665] New: Web Inspector: Agent commands do not actually return a promise when expected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138665

            Bug ID: 138665
           Summary: Web Inspector: Agent commands do not actually return a
                    promise when expected
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: burg at cs.washington.edu
                CC: graouts at webkit.org, joepeck at webkit.org,
                    timothy at apple.com, webkit-bug-importer at group.apple.com

It seems that LayoutTests/inspector/protocol-return-promise.html is buggy, masking the error. It's only found now because Jono tried to .then on an agent command without .promise().

We don't actually return a promise from InspectorBackend.Command.create.(fn callable). That's because invokeWithArguments doesn't return a promise either- we need to convert the manual callback to a promise in (fn callable) like we do in InspectorBackend.Command.promise.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141112/e8480500/attachment-0002.html>