[Webkit-unassigned] [Bug 138657] Video as image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138657

--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 241422
  --> https://bugs.webkit.org/attachment.cgi?id=241422
wip patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241422&action=review

Nice!

> Source/WebCore/platform/graphics/VideoImage.cpp:84
> +    if (m_player->readyState() >= MediaPlayer::HaveEnoughData)
> +        m_frameTimer.startOneShot(16_ms);
> +
> +    if (m_player->duration() > MediaTime::zeroTime() && m_player->currentTime() >= m_player->duration()) {
> +        fprintf(stderr, "seeking %d\n", m_player->readyState());
> +        m_player->seek(MediaTime::zeroTime());
> +    }

It seems like we should seek to the next frame if possible instead of using a hard coded interval. How about adding MediaPlayer::step(int numberOfFrames) - and have the default MediaPlayerPrivate implementation seek 16_ms * numberOfFrames so it works like this does until ports implement stepping logic?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141112/83df2e99/attachment-0002.html>