[Webkit-unassigned] [Bug 137918] Use references instead of pointers in EditingStyle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 11 09:34:05 PST 2014


Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
 Attachment #241350|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 241350
  --> https://bugs.webkit.org/attachment.cgi?id=241350
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=241350&action=review

r=me with one fix before landing.

> Source/WebCore/editing/EditingStyle.cpp:1520
> +    if (!is<CSSPrimitiveValue>(&fontWeight))

No, this is wrong. You will do an unnecessary null check. Just use if (!is<CSSPrimitiveValue>(fontWeight))

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141111/85c9616c/attachment-0002.html>

More information about the webkit-unassigned mailing list