[Webkit-unassigned] [Bug 137918] Use references instead of pointers in EditingStyle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 11 04:06:22 PST 2014


Tibor Mészáros <tmeszaros.u-szeged at partner.samsung.com> changed:

           What    |Removed                     |Added
 Attachment #241109|0                           |1
        is obsolete|                            |
 Attachment #241349|                            |review?, commit-queue?
              Flags|                            |

--- Comment #6 from Tibor Mészáros <tmeszaros.u-szeged at partner.samsung.com> ---
Created attachment 241349
  --> https://bugs.webkit.org/attachment.cgi?id=241349&action=review
Patch v2

Almost all of the suggested change has been taken, but some not:

> Source/WebCore/editing/EditingStyle.cpp:344
> +    m_mutableStyle = style.mutableCopy();

Can this be moved to the initializer list now?

No, it could not be moved to initializer list, because style could be nullptr.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:489
> +        RefPtr<EditingStyle> newInlineStyle = EditingStyle::create(*inlineStyle);

Why is this safe? There is a null check right after...

This change has been removed from the patch.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:791
> +    RefPtr<EditingStyle> style = EditingStyle::create(*wrappingStyleSpan->inlineStyle());

Why is this safe?

This change has been removed too.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141111/e488ecff/attachment-0002.html>

More information about the webkit-unassigned mailing list