[Webkit-unassigned] [Bug 130237] Webkitgtk3 crashes on PPC64 due to mprotect() on address not aligned to the page size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 10 01:41:25 PST 2014


Alberto Garcia <berto at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #226710|0                           |1
        is obsolete|                            |
 Attachment #241283|                            |review?
              Flags|                            |

--- Comment #3 from Alberto Garcia <berto at igalia.com> ---
Created attachment 241283
  --> https://bugs.webkit.org/attachment.cgi?id=241283&action=review

Thanks for the patch. I don't know the JSC internals so I cannot review it myself.

However defining a local 'commitsize' to override the global constant 'commitSize' is very confusing. Either use a different name or use pageSize() directly.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141110/d8063776/attachment-0002.html>

More information about the webkit-unassigned mailing list