[Webkit-unassigned] [Bug 138549] Remove BloomFilter size limit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138549

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
(In reply to comment #2)
> Comment on attachment 241261 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241261&action=review
> 
> > Source/WTF/wtf/BloomFilter.h:-40
> > -    static_assert(keyBits <= 16, "BloomFilter key size must be less than or equal to 16!");
> 
> Shouldn't we make sure it is at least <= 32 so that 1 << keyBits below
> doesn't overflow?
> 
> I have looked carefully at the implementation but was this 16 value somehow
> corrected to the 16 value used in secondSlot() below?

typo: s/corrected/connected

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141109/bd6f218f/attachment-0002.html>