[Webkit-unassigned] [Bug 133359] [CSS Grid Layout] Upgrade align-self and align-items parsing to CSS 3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133359

--- Comment #54 from Benjamin Poulain <benjamin at webkit.org> ---
Comment on attachment 240511
  --> https://bugs.webkit.org/attachment.cgi?id=240511
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240511&action=review

I don't think I should r+. I would like Dave Hyatt to have a look.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1275
> +                // FIXME: https://webkit.org/b/135460 - The extended grammar is not supported
> +                // yet for FlexibleBox.
> +                // Defaulting to Stretch for now, as it what most of FlexBox based renders
> +                // expect as default.

I would add notImplemented() here.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1309
> +                // FIXME: https://webkit.org/b/135460 - The extended grammar is not supported
> +                // yet for FlexibleBox.

ditto

> Source/WebCore/style/StyleResolveTree.cpp:125
> +    if (s1->alignItems() != s2->alignItems())

Wait, what?

How did that not break tests?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141108/9b12076d/attachment-0002.html>