[Webkit-unassigned] [Bug 138510] Fix an alignment issue with operationPushCatchScope on ARMv7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138510

Csaba Osztrogonác <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241196|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Csaba Osztrogonác <ossy at webkit.org> ---
Comment on attachment 241196
  --> https://bugs.webkit.org/attachment.cgi?id=241196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241196&action=review

r=me , but CQ-, because it depends on bug138254

> Source/JavaScriptCore/jit/JITInlines.h:586
> -    setupArgumentsWithExecState(TrustedImm32(op1), TrustedImmPtr(identOp2), regOp3Payload, regOp3Tag, TrustedImm32(op4));
> +    setupArgumentsWithExecState(TrustedImm32(op1), TrustedImmPtr(identOp2), EABI_32BIT_DUMMY_ARG regOp3Payload, regOp3Tag, TrustedImm32(op4));

Good catch, ARM EABI doesn't like splitting the 64 bit sized JSValue to r3 and stack.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141107/800e161c/attachment-0002.html>