[Webkit-unassigned] [Bug 138499] Enable Cortex-A53-specific code paths by default if core is detected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138499

--- Comment #2 from Csaba Osztrogonác <ossy at webkit.org> ---
Comment on attachment 241168
  --> https://bugs.webkit.org/attachment.cgi?id=241168
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=241168&action=review

> Source/cmake/OptionsCommon.cmake:36
> +    if (CPUINFO MATCHES "0xd03")

I would restrict matching "0xd03" only in "CPU part" line to avoid accidental matches.

And could you possibly add a comment to the ARM reference?
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0500f/BABFEABI.html

> Source/cmake/OptionsCommon.cmake:37
> +        set(WTF_CPU_ARM64_CORTEXA53_INITIALVALUE ON)

Why not set(WTF_CPU_ARM64_CORTEXA53 1) and add_definitions(-DWTF_CPU_ARM64_CORTEXA53=1) ?
In this case we wouldn't need WTF_CPU_ARM64_CORTEXA53_INITIALVALUE and the option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141107/d1cf569b/attachment-0002.html>