[Webkit-unassigned] [Bug 138472] Preview views often misplaced inside popover

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138472

--- Comment #4 from Anders Carlsson <andersca at apple.com> ---
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:328
> +- (BOOL)_targetSize:(NSSize)targetSize fitsInAvailableSpace:(NSSize)availableSpace
> +{
> +    return targetSize.width <= availableSpace.width && targetSize.height <= availableSpace.height;
> +}

I think this should just be a static C function

bool targetSizeFitsInAvailableSpace(NSSize targetSize, NSSize availableSpace) 
{
}

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:359
> +    FloatRect maxHortizontalTargetSizePreservingAspectRatioRect = largestRectWithAspectRatioInsideRect(aspectRatio, FloatRect(0, 0, maxSpaceAvailableOnXEdge.width, maxSpaceAvailableOnXEdge.height));

Hortizontal! (Tim Hortizontal)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141106/fb638e62/attachment-0002.html>