[Webkit-unassigned] [Bug 137849] [GTK] [Stable] webkitgtk 2.6.1 fails to load flashplugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137849

Alberto Garcia <berto at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241098|0                           |1
        is obsolete|                            |
 Attachment #241106|                            |review?
              Flags|                            |

--- Comment #13 from Alberto Garcia <berto at igalia.com> ---
Created attachment 241106
  --> https://bugs.webkit.org/attachment.cgi?id=241106&action=review
Patch

I'm stupid, forget my previous comments. We are actually having the
stack corrupted.

The reason is that although NPPVpluginNeedsXEmbed is a boolean value
we cannot use bool/NPBool there (1 byte) because the Flash player
plugin (and possibly others) are using an int instead.

My confusion came from the fact that it doesn't happen when we disable
optimizations. The reason for that might be that in that case we would
be overwriting the windowID variable instead, which is not a problem
because we would not be changing its current value (0).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141106/5cbf17c3/attachment-0002.html>